net: nixge: Fix error path for obtaining mac address
authorMoritz Fischer <mdf@kernel.org>
Fri, 4 May 2018 17:18:33 +0000 (10:18 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 May 2018 03:30:03 +0000 (23:30 -0400)
commitabcd3d6fc640aff48b17900734eff134f27fdf2a
treeb6d7bb613de4014751562c425a72ef1542a009a0
parent1751eb42ddb56b1e0a28ade5c5f19b7961a6f0c2
net: nixge: Fix error path for obtaining mac address

Fix issue where nixge_get_nvmem_address() returns a non-NULL
return value on a failed nvmem_cell_get() that causes an invalid
access when error value encoded in pointer is dereferenced.

Furthermore ensure that buffer allocated by nvmem_cell_read()
actually gets kfreed() if the function succeeds.

Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for
National Instruments XGE netdev")
Reported-by: Alex Williams <alex.williams@ni.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ni/nixge.c