dm table: fix regression from improper dm_dev_internal.count refcount_t conversion
authorMike Snitzer <snitzer@redhat.com>
Sat, 25 Nov 2017 05:27:26 +0000 (00:27 -0500)
committerMike Snitzer <snitzer@redhat.com>
Mon, 4 Dec 2017 15:23:10 +0000 (10:23 -0500)
commitafc567a4977b2d798e05153dd131a3c8d4758c0c
tree8d5abb8627ae852a7dc191ffac9dfb27c58d1635
parentae64f9bd1d3621b5e60d7363bc20afb46aede215
dm table: fix regression from improper dm_dev_internal.count refcount_t conversion

Multiple refcounts are needed if the device was already added.  The
micro-optimization of setting the refcount to 1 on first added (rather
than fall thru to a common refcount_inc) lost sight of the fact that the
refcount_inc is also needed for the case when the device already exists
and the mode need not be upgraded.

Fixes: 2a0b4682e0 ("dm: convert dm_dev_internal.count from atomic_t to refcount_t")
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-table.c