nsh: set mac len based on inner packet
authorWillem de Bruijn <willemb@google.com>
Wed, 11 Jul 2018 16:00:44 +0000 (12:00 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jul 2018 23:55:29 +0000 (16:55 -0700)
commitbab2c80e5a6c855657482eac9e97f5f3eedb509a
tree737e565888fea5804ed4723789e1b604259ad5d6
parent8b7008620b8452728cadead460a36f64ed78c460
nsh: set mac len based on inner packet

When pulling the NSH header in nsh_gso_segment, set the mac length
based on the encapsulated packet type.

skb_reset_mac_len computes an offset to the network header, which
here still points to the outer packet:

  >     skb_reset_network_header(skb);
  >     [...]
  >     __skb_pull(skb, nsh_len);
  >     skb_reset_mac_header(skb);    // now mac hdr starts nsh_len == 8B after net hdr
  >     skb_reset_mac_len(skb);       // mac len = net hdr - mac hdr == (u16) -8 == 65528
  >     [..]
  >     skb_mac_gso_segment(skb, ..)

Link: http://lkml.kernel.org/r/CAF=yD-KeAcTSOn4AxirAxL8m7QAS8GBBe1w09eziYwvPbbUeYA@mail.gmail.com
Reported-by: syzbot+7b9ed9872dab8c32305d@syzkaller.appspotmail.com
Fixes: c411ed854584 ("nsh: add GSO support")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nsh/nsh.c