block: only bdi_unregister() in del_gendisk() if !GENHD_FL_HIDDEN
authorMike Snitzer <snitzer@redhat.com>
Wed, 10 Jan 2018 01:46:49 +0000 (20:46 -0500)
committerJens Axboe <axboe@kernel.dk>
Mon, 15 Jan 2018 15:41:38 +0000 (08:41 -0700)
commitbc8d062c36e3525e81ea8237ff0ab3264c2317b6
tree9385753a2d290add6cad65051d08db5ed5223e2c
parentbf9ae8c5325c0070d0ec81a849bba8d156f65993
block: only bdi_unregister() in del_gendisk() if !GENHD_FL_HIDDEN

device_add_disk() will only call bdi_register_owner() if
!GENHD_FL_HIDDEN, so it follows that del_gendisk() should only call
bdi_unregister() if !GENHD_FL_HIDDEN.

Found with code inspection.  bdi_unregister() won't do any harm if
bdi_register_owner() wasn't used but best to avoid the unnecessary
call to bdi_unregister().

Fixes: 8ddcd65325 ("block: introduce GENHD_FL_HIDDEN")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/genhd.c