scsi: core: set result when the command cannot be dispatched
authorJaesoo Lee <jalee@purestorage.com>
Wed, 10 Apr 2019 00:02:22 +0000 (17:02 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Apr 2019 02:35:20 +0000 (22:35 -0400)
commitbe549d49115422f846b6d96ee8fd7173a5f7ceb0
treead5b525675171e31510bf6755f7712c2b17ca64a
parent5c2442fd78998af60e13aba506d103f7f43f8701
scsi: core: set result when the command cannot be dispatched

When SCSI blk-mq is enabled, there is a bug in handling errors in
scsi_queue_rq.  Specifically, the bug is not setting result field of
scsi_request correctly when the dispatch of the command has been
failed. Since the upper layer code including the sg_io ioctl expects to
receive any error status from result field of scsi_request, the error is
silently ignored and this could cause data corruptions for some
applications.

Fixes: d285203cf647 ("scsi: add support for a blk-mq based I/O path.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Jaesoo Lee <jalee@purestorage.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_lib.c