xfs: clear cowblocks tag when cow fork is emptied
authorBrian Foster <bfoster@redhat.com>
Mon, 24 Oct 2016 03:21:08 +0000 (14:21 +1100)
committerDave Chinner <david@fromorbit.com>
Mon, 24 Oct 2016 03:21:08 +0000 (14:21 +1100)
commitc17a8ef43d6b80ed3519b828c37d18645445949f
tree8f67f36ae789c6ee7888f905b9daf700518fea40
parent7b7381f043568224af798b1decb607dca97b4114
xfs: clear cowblocks tag when cow fork is emptied

The background cowblocks scan job takes care of scanning for inodes with
potentially lingering blocks in the cow fork and clearing them out. If
the background scanner reclaims the cow fork blocks, however, it doesn't
immediately clear the cowblocks tag from the inode. Instead, the inode
remains tagged until the background scanner comes around again,
discovers the inode cow fork has no blocks, clears the tag and fires the
trace_xfs_inode_free_cowblocks_invalid() tracepoint to indicate that the
inode may have been incorrectly tagged.

This is not a major functional problem as the tag is ultimately cleared.
Nonetheless, clear the tag when an inode cow fork is explicitly emptied
to avoid the extra round trip through the background scanner and
spurious "invalid" tracepoint.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_reflink.c