drm/vmwgfx: Don't double-free the mode stored in par->set_mode
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 18 Mar 2019 14:47:58 +0000 (15:47 +0100)
committerThomas Hellstrom <thellstrom@vmware.com>
Wed, 20 Mar 2019 06:57:01 +0000 (07:57 +0100)
commitc2d311553855395764e2e5bf401d987ba65c2056
treebf52dab89a4e1598ed5d7d15997bbf6bad3db15b
parent4b9ce3a651a37c60527101db4451a315a8b9588f
drm/vmwgfx: Don't double-free the mode stored in par->set_mode

When calling vmw_fb_set_par(), the mode stored in par->set_mode gets free'd
twice. The first free is in vmw_fb_kms_detach(), the second is near the
end of vmw_fb_set_par() under the name of 'old_mode'. The mode-setting code
only works correctly if the mode doesn't actually change. Removing
'old_mode' in favor of using par->set_mode directly fixes the problem.

Cc: <stable@vger.kernel.org>
Fixes: a278724aa23c ("drm/vmwgfx: Implement fbdev on kms v2")
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Deepak Rawat <drawat@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c