clk: hisilicon: fix potential NULL dereference in hisi_clk_alloc()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 20 Mar 2018 14:19:34 +0000 (14:19 +0000)
committerStephen Boyd <sboyd@kernel.org>
Tue, 20 Mar 2018 17:23:41 +0000 (10:23 -0700)
commitc744b63b6c422776293cc526ef7887623926f33e
treea938b855ef452ca0f3c2ce07572d4de61d158b35
parentdf934cbcbff7afbc024bf05f02615917c61f6470
clk: hisilicon: fix potential NULL dereference in hisi_clk_alloc()

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Fixes: 322269163a36 ("clk: hisilicon: add hisi_clk_alloc function.")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/hisilicon/clk.c