s390/cio: fix accidental interrupt enabling during resume
authorSebastian Ott <sebott@linux.vnet.ibm.com>
Wed, 28 Sep 2016 11:36:19 +0000 (13:36 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Fri, 30 Sep 2016 07:13:11 +0000 (09:13 +0200)
commitd53c51f26145657aa7c55fa396f93677e613548d
tree0d76b2a11aa079c9f532a8457524f61d29ffd297
parent871f8bf0c477ef20ac1457bb241416d7d8749732
s390/cio: fix accidental interrupt enabling during resume

Since commit 9f3d6d7 chsc_get_channel_measurement_chars is called with
interrupts disabled during resume from hibernate. Since this function
used spin_unlock_irq, interrupts have been enabled accidentally. Fix
this by using the irqsave variant.

Since we can't guarantee the IRQ-enablement state for all (future/
external) callers, change the locking in related functions to prevent
similar bugs in the future.

Fixes: 9f3d6d7 ("s390/cio: update measurement characteristics")
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/cio/chsc.c