ALSA: hda: Fix racy display power access
authorTakashi Iwai <tiwai@suse.de>
Wed, 10 Apr 2019 10:49:55 +0000 (12:49 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 10 Apr 2019 13:23:36 +0000 (15:23 +0200)
commitd7a181da2dfa3190487c446042ba01e07d851c74
treec2c281018d0a0dd56e792e0fca49af8313d5a30b
parentcae30527901d9590db0e12ace994c1d58bea87fd
ALSA: hda: Fix racy display power access

snd_hdac_display_power() doesn't handle the concurrent calls carefully
enough, and it may lead to the doubly get_power or put_power calls,
when a runtime PM and an async work get called in racy way.

This patch addresses it by reusing the bus->lock mutex that has been
used for protecting the link state change in ext bus code, so that it
can protect against racy display state changes.  The initialization of
bus->lock was moved from snd_hdac_ext_bus_init() to
snd_hdac_bus_init() as well accordingly.

Testcase: igt/i915_pm_rpm/module-reload #glk-dsi
Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/ext/hdac_ext_bus.c
sound/hda/hdac_bus.c
sound/hda/hdac_component.c