net: phy: fix too strict check in phy_start_aneg
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 9 Jan 2019 19:34:56 +0000 (20:34 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Jan 2019 21:33:44 +0000 (13:33 -0800)
commitd9f903f6af3dc6d13b21c0eca8f4a169aa70d80d
tree4f1203cdd10f6b4fa5cec836d7fd08d60a406974
parent5642e27bf6a935c1d0d9149e83d625dfba286463
net: phy: fix too strict check in phy_start_aneg

When adding checks to detect wrong usage of the phylib API we added
a check to phy_start_aneg() which is too strict. If the phylib
state machine is in state PHY_HALTED we should allow reconfiguring
and restarting aneg, and just don't touch the state.

Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c