projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4dc69c1) | patch
qlge: Avoid reading past end of buffer
authorKees Cook <keescook@chromium.org>
Fri, 5 May 2017 22:34:34 +0000 (15:34 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 May 2017 18:41:42 +0000 (14:41 -0400)
commitdf5303a8aa9a0a6934f4cea7427f1edf771f21c2
tree79883fc3aec97f06d50968e693fa917e3c275e4ctree | snapshot
parent4dc69c1c1fff2f587f8e737e70b4a4e7565a5c94commit | diff
qlge: Avoid reading past end of buffer

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlge/qlge_dbg.c diff | blob | history
John Crispins staging tree