bpf: fix NULL deref in btf_type_is_resolve_source_only
authorStanislav Fomichev <sdf@google.com>
Wed, 19 Jun 2019 19:01:05 +0000 (12:01 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 24 Jun 2019 13:53:19 +0000 (15:53 +0200)
commite4f07120210a1794c1f1ae64d209a2fbc7bd2682
treed606d6fca52f90e1729dc690f1ec88e705d89b93
parent56f0f84e69c7a7f229dfa524b13b0ceb6ce9b09e
bpf: fix NULL deref in btf_type_is_resolve_source_only

Commit 1dc92851849c ("bpf: kernel side support for BTF Var and DataSec")
added invocations of btf_type_is_resolve_source_only before
btf_type_nosize_or_null which checks for the NULL pointer.
Swap the order of btf_type_nosize_or_null and
btf_type_is_resolve_source_only to make sure the do the NULL pointer
check first.

Fixes: 1dc92851849c ("bpf: kernel side support for BTF Var and DataSec")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/btf.c