x86/spinlocks: Fix regression in spinlock contention detection
authorTahsin Erdogan <tahsin@google.com>
Tue, 5 May 2015 04:15:31 +0000 (21:15 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 5 May 2015 09:01:38 +0000 (11:01 +0200)
commite8a4a2696fecb398b0288c43c0e0dbb91e265bb2
tree61b8b75b02cfbb8a6634792b8c686bd4e8ca01c5
parent94d4b4765b7ddb8478b0d57663cf7a08e2263bbf
x86/spinlocks: Fix regression in spinlock contention detection

A spinlock is regarded as contended when there is at least one waiter.
Currently, the code that checks whether there are any waiters rely on
tail value being greater than head. However, this is not true if tail
reaches the max value and wraps back to zero, so arch_spin_is_contended()
incorrectly returns 0 (not contended) when tail is smaller than head.

The original code (before regression) handled this case by casting the
(tail - head) to an unsigned value. This change simply restores that
behavior.

Fixes: d6abfdb20223 ("x86/spinlocks/paravirt: Fix memory corruption on unlock")
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Cc: peterz@infradead.org
Cc: Waiman.Long@hp.com
Cc: borntraeger@de.ibm.com
Cc: oleg@redhat.com
Cc: raghavendra.kt@linux.vnet.ibm.com
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1430799331-20445-1-git-send-email-tahsin@google.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/include/asm/spinlock.h