vxlan: fix default fdb entry netlink notify ordering during netdev create
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Fri, 20 Jul 2018 20:21:04 +0000 (13:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Jul 2018 17:52:37 +0000 (10:52 -0700)
commite99465b952861533d9ba748fdbecc96d9a36da3e
tree98b448481cc3ad9443a3e257e05f071b1233a24d
parentf6e053858671bb156b6e44ad66418acc8c7f4e77
vxlan: fix default fdb entry netlink notify ordering during netdev create

Problem:
In vxlan_newlink, a default fdb entry is added before register_netdev.
The default fdb creation function also notifies user-space of the
fdb entry on the vxlan device which user-space does not know about yet.
(RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex).

This patch fixes the user-space netlink notification ordering issue
with the following changes:
- decouple fdb notify from fdb create.
- Move fdb notify after register_netdev.
- Call rtnl_configure_link in vxlan newlink handler to notify
userspace about the newlink before fdb notify and
hence avoiding the user-space race.

Fixes: afbd8bae9c79 ("vxlan: add implicit fdb entry for default destination")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c