regulator: da9063: fix DT probing with constraints
authorPhilipp Zabel <p.zabel@pengutronix.de>
Fri, 31 Aug 2018 12:34:02 +0000 (14:34 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 31 Aug 2018 14:55:54 +0000 (15:55 +0100)
commitef394f3fbecbe61d69450ad8cf0fa8f713c8ce8f
tree8555fac064ba3f18fa9e58571f45cacac890acd1
parent823f18f8b860526fc099c222619a126d57d2ad8c
regulator: da9063: fix DT probing with constraints

Commit 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L")
reordered the da9063_regulator_info[] array, but not the DA9063_ID_*
regulator ids and not the da9063_matches[] array, because ids are used
as indices in the array initializer. This mismatch between regulator id
and da9063_regulator_info[] array index causes the driver probe to fail
because constraints from DT are not applied to the correct regulator:

  da9063 0-0058: Device detected (chip-ID: 0x61, var-ID: 0x50)
  DA9063_BMEM: Bringing 900000uV into 3300000-3300000uV
  DA9063_LDO9: Bringing 3300000uV into 2500000-2500000uV
  DA9063_LDO1: Bringing 900000uV into 3300000-3300000uV
  DA9063_LDO1: failed to apply 3300000-3300000uV constraint(-22)

This patch reorders the DA9063_ID_* as apparently intended, and with
them the entries in the da90630_matches[] array.

Fixes: 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/linux/mfd/da9063/pdata.h