usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Wed, 29 May 2013 20:51:37 +0000 (00:51 +0400)
committerFelipe Balbi <balbi@ti.com>
Mon, 10 Jun 2013 14:08:48 +0000 (17:08 +0300)
commitf37d49ad6e3d351fcf3cd042953ff273b6cd47e0
tree54db39fe36fc29ea34c0ba6d2ab72c75ed88798b
parenta2cc81d315c45cce35c0e50716fbee5dc00e28aa
usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq()

r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking r8a66597->lock.
But transfer_complete(), that is called inside (r8a66597_sudmac_irq()->sudmac_finish()->transfer_complete()),
expects r8a66597->lock is locked. As a result unheld spinlock can be unlocked.

The patch just moves locking before calling r8a66597_sudmac_irq().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/r8a66597-udc.c