projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cc4acb1) | patch
xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi
authorYueHaibing <yuehaibing@huawei.com>
Wed, 19 Dec 2018 06:45:09 +0000 (14:45 +0800)
committerSteffen Klassert <steffen.klassert@secunet.com>
Wed, 19 Dec 2018 11:33:17 +0000 (12:33 +0100)
commitfa89a4593b927b3f59c3b69379f31d3b22272e4e
tree7569a640cb733f84f1849f1793cac61a5ab183dftree | snapshot
parentcc4acb1b6a86563ef5b6dc7c35d99f66d7b82557commit | diff
xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi

gcc warn this:

net/ipv6/xfrm6_tunnel.c:143 __xfrm6_tunnel_alloc_spi() warn:
 always true condition '(spi <= 4294967295) => (0-u32max <= u32max)'

'spi' is u32, which always not greater than XFRM6_TUNNEL_SPI_MAX
because of wrap around. So the second forloop will never reach.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv6/xfrm6_tunnel.c diff | blob | history
John Crispins staging tree