i2c: designware: must wait for enable
authorBen Gardner <gardner.ben@gmail.com>
Wed, 14 Feb 2018 15:29:52 +0000 (09:29 -0600)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 21 Feb 2018 08:15:47 +0000 (09:15 +0100)
commitfba4adbbf670577e605f9ad306629db6031cd48b
treed2ba3f45d4edbeed43f974758cafa60837de3455
parent91ab883eb21325ad80f3473633f794c78ac87f51
i2c: designware: must wait for enable

One I2C bus on my Atom E3845 board has been broken since 4.9.
It has two devices, both declared by ACPI and with built-in drivers.

There are two back-to-back transactions originating from the kernel, one
targeting each device. The first transaction works, the second one locks
up the I2C controller. The controller never recovers.

These kernel logs show up whenever an I2C transaction is attempted after
this failure.
i2c-designware-pci 0000:00:18.3: timeout in disabling adapter
i2c-designware-pci 0000:00:18.3: timeout waiting for bus ready

Waiting for the I2C controller status to indicate that it is enabled
before programming it fixes the issue.

I have tested this patch on 4.14 and 4.15.

Fixes: commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only if necessary")
Cc: linux-stable <stable@vger.kernel.org> #4.13+
Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-master.c