luci-static: fix race condition when probing features master
authorPaul Donald <newtwen+github@gmail.com>
Wed, 24 Dec 2025 16:34:16 +0000 (17:34 +0100)
committerPaul Donald <newtwen+github@gmail.com>
Wed, 24 Dec 2025 16:34:16 +0000 (17:34 +0100)
commitdb91dbcdf7db16b307aaf054a6039a6abc464b0c
tree94ff4d5dc68d5eed9da0a1d389368d31b504e2c4
parent74d2192e83f842f6bc1058f16871d5dd1edae51b
luci-static: fix race condition when probing features

follow-up to a2fce95248a260d9471efbff94ad0cde7a90700d

hasSystemFeature() inspects the cached result of
probeSystemFeatures() which needs to have completed.

Once all of the legacy (Lua) stuff is ready, this block
runs:

initDOM() {
...
L.loaded = true;
document.dispatchEvent(new CustomEvent('luci-loaded'));
},

This commit now calls View.load() once system feature
probing has completed, and LuCI itself has loaded. This
ensures that the following load paradigm succeeds:

return view.extend({
load() {
return Promise.all([
...,
L.hasSystemFeature('x'),
]);
}, ...

The luci-loaded check prevents waiting when LuCI is already
loaded (the common case after initial page load), but the
listener handles the race condition where a View is
instantiated before initDOM() completes.

The flow:

If L.loaded is true: initDOM() already ran --> skip waiting,
proceed immediately.

If L.loaded is false: initDOM() hasn't run yet --> add
listener --> wait for it to complete.

Signed-off-by: Paul Donald <newtwen+github@gmail.com>
modules/luci-base/htdocs/luci-static/resources/luci.js