btrfs: squeeze btrfs_dev_replace_continue_on_mount to its caller
authorDavid Sterba <dsterba@suse.com>
Tue, 20 Mar 2018 14:35:50 +0000 (15:35 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 28 May 2018 16:07:22 +0000 (18:07 +0200)
The function is called once and is fairly small, we can merge it with
the caller.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c

index f82be266ba4ba6dfb8fe3eb4ec2160beb080d77a..db4d08c651311581a7f2c739767128f024b46aee 100644 (file)
@@ -33,8 +33,6 @@ static void btrfs_dev_replace_update_device_in_mapping_tree(
                                                struct btrfs_device *srcdev,
                                                struct btrfs_device *tgtdev);
 static int btrfs_dev_replace_kthread(void *data);
-static int btrfs_dev_replace_continue_on_mount(struct btrfs_fs_info *fs_info);
-
 
 int btrfs_init_dev_replace(struct btrfs_fs_info *fs_info)
 {
@@ -810,6 +808,7 @@ static int btrfs_dev_replace_kthread(void *data)
        struct btrfs_fs_info *fs_info = data;
        struct btrfs_dev_replace *dev_replace = &fs_info->dev_replace;
        u64 progress;
+       int ret;
 
        progress = btrfs_dev_replace_progress(fs_info);
        progress = div_u64(progress, 10);
@@ -820,23 +819,14 @@ static int btrfs_dev_replace_kthread(void *data)
                btrfs_dev_name(dev_replace->tgtdev),
                (unsigned int)progress);
 
-       btrfs_dev_replace_continue_on_mount(fs_info);
-       clear_bit(BTRFS_FS_EXCL_OP, &fs_info->flags);
-
-       return 0;
-}
-
-static int btrfs_dev_replace_continue_on_mount(struct btrfs_fs_info *fs_info)
-{
-       struct btrfs_dev_replace *dev_replace = &fs_info->dev_replace;
-       int ret;
-
        ret = btrfs_scrub_dev(fs_info, dev_replace->srcdev->devid,
                              dev_replace->committed_cursor_left,
                              btrfs_device_get_total_bytes(dev_replace->srcdev),
                              &dev_replace->scrub_progress, 0, 1);
        ret = btrfs_dev_replace_finishing(fs_info, ret);
        WARN_ON(ret);
+
+       clear_bit(BTRFS_FS_EXCL_OP, &fs_info->flags);
        return 0;
 }