staging: ccree: Convert to platform_{get,set}_drvdata()
authorSuniel Mahesh <sunil.m@techveda.org>
Wed, 4 Oct 2017 07:45:37 +0000 (13:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Oct 2017 08:26:34 +0000 (10:26 +0200)
Platform devices are expected to use wrapper functions,
platform_{get,set}_drvdata() with platform_device as argument,
for getting and setting the driver data. dev_{get,set}_drvdata()
are using &plat_dev->dev.
For wrapper functions we can directly pass a struct platform_device.

dev_set_drvdata() is redundant and therefore removed. The driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_driver.c

index 795a087d45a4a2e89f4337f2f45ed3665c96602c..5f03c2596f4566019026147ab3acdc07445d6e53 100644 (file)
@@ -215,7 +215,7 @@ static int init_cc_resources(struct platform_device *plat_dev)
                rc = -ENOMEM;
                goto post_drvdata_err;
        }
-       dev_set_drvdata(dev, new_drvdata);
+       platform_set_drvdata(plat_dev, new_drvdata);
        new_drvdata->plat_dev = plat_dev;
 
        new_drvdata->clk = of_clk_get(np, 0);
@@ -393,7 +393,6 @@ post_clk_err:
        cc_clk_off(new_drvdata);
 post_drvdata_err:
        dev_err(dev, "ccree init error occurred!\n");
-       dev_set_drvdata(dev, NULL);
        return rc;
 }
 
@@ -407,7 +406,7 @@ void fini_cc_regs(struct ssi_drvdata *drvdata)
 static void cleanup_cc_resources(struct platform_device *plat_dev)
 {
        struct ssi_drvdata *drvdata =
-               (struct ssi_drvdata *)dev_get_drvdata(&plat_dev->dev);
+               (struct ssi_drvdata *)platform_get_drvdata(plat_dev);
 
        ssi_aead_free(drvdata);
        ssi_hash_free(drvdata);
@@ -423,7 +422,6 @@ static void cleanup_cc_resources(struct platform_device *plat_dev)
 #endif
        fini_cc_regs(drvdata);
        cc_clk_off(drvdata);
-       dev_set_drvdata(&plat_dev->dev, NULL);
 }
 
 int cc_clk_on(struct ssi_drvdata *drvdata)