rxrpc: Fix Tx ring annotation after initial Tx failure

rxrpc calls have a ring of packets that are awaiting ACK or retransmission
and a parallel ring of annotations that tracks the state of those packets.
If the initial transmission of a packet on the underlying UDP socket fails
then the packet annotation is marked for resend - but the setting of this
mark accidentally erases the last-packet mark also stored in the same
annotation slot.  If this happens, a call won't switch out of the Tx phase
when all the packets have been transmitted.

Fix this by retaining the last-packet mark and only altering the packet
state.

Fixes: 248f219cb8bc ("rxrpc: Rewrite the data and ack handling code")
Signed-off-by: David Howells <dhowells@redhat.com>

diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c
index 8503f279b4671211374187d5a876d5c65f320e65..783c777fc6e79ac9b4b30c2946eae192f572d8a0 100644 (file)
--- a/net/rxrpc/sendmsg.c
+++ b/net/rxrpc/sendmsg.c
@@ -130,7 +130,9 @@ static inline void rxrpc_instant_resend(struct rxrpc_call *call, int ix)
        spin_lock_bh(&call->lock);
 
        if (call->state < RXRPC_CALL_COMPLETE) {
-               call->rxtx_annotations[ix] = RXRPC_TX_ANNO_RETRANS;
+               call->rxtx_annotations[ix] =
+                       (call->rxtx_annotations[ix] & RXRPC_TX_ANNO_LAST) |
+                       RXRPC_TX_ANNO_RETRANS;
                if (!test_and_set_bit(RXRPC_CALL_EV_RESEND, &call->events))
                        rxrpc_queue_call(call);
        }