media: em28xx-camera: fix coding style issues
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 3 Mar 2018 17:17:54 +0000 (12:17 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Mar 2018 10:54:53 +0000 (05:54 -0500)
There are some coding style issues at em28xx-camera.

Fix them, by using checkpatch in strict mode to point for it.
Automatic fixes with --fix-inplace were complemented by manual
work.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/em28xx/em28xx-camera.c

index f0c52da1737263bf2dd153a0f4c628d2261da5a3..3c2694a16ed14a8d98477bbfc67883389a496d2a 100644 (file)
@@ -45,7 +45,7 @@ static int em28xx_initialize_mt9m111(struct em28xx *dev)
                { 0x0d, 0x00, 0x01, },  /* reset and use defaults */
                { 0x0d, 0x00, 0x00, },
                { 0x0a, 0x00, 0x21, },
-               { 0x21, 0x04, 0x00, },  /* full readout speed, no row/col skipping */
+               { 0x21, 0x04, 0x00, },  /* full readout spd, no row/col skip */
        };
 
        for (i = 0; i < ARRAY_SIZE(regs); i++)
@@ -153,7 +153,8 @@ static int em28xx_probe_sensor_micron(struct em28xx *dev)
                        break;
                default:
                        dev_info(&dev->intf->dev,
-                                "unknown Micron sensor detected: 0x%04x\n", id);
+                                "unknown Micron sensor detected: 0x%04x\n",
+                                id);
                        return 0;
                }
 
@@ -182,8 +183,10 @@ static int em28xx_probe_sensor_omnivision(struct em28xx *dev)
        struct i2c_client *client = &dev->i2c_client[dev->def_i2c_bus];
 
        dev->em28xx_sensor = EM28XX_NOSENSOR;
-       /* NOTE: these devices have the register auto incrementation disabled
-        * by default, so we have to use single byte reads !              */
+       /*
+        * NOTE: these devices have the register auto incrementation disabled
+        * by default, so we have to use single byte reads !
+        */
        for (i = 0; omnivision_sensor_addrs[i] != I2C_CLIENT_END; i++) {
                client->addr = omnivision_sensor_addrs[i];
                /* Read manufacturer ID from registers 0x1c-0x1d (BE) */
@@ -393,7 +396,7 @@ int em28xx_init_camera(struct em28xx *dev)
                subdev =
                     v4l2_i2c_new_subdev_board(&v4l2->v4l2_dev, adap,
                                               &ov2640_info, NULL);
-               if (subdev == NULL)
+               if (!subdev)
                        return -ENODEV;
 
                format.format.code = MEDIA_BUS_FMT_YUYV8_2X8;