media: bt8xx: avoid a needless u8 to char conversion

Instead of doing the cast, just change the type to char.

Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/pci/bt8xx/dst.c b/drivers/media/pci/bt8xx/dst.c
index 3315a6d67edf17de24cbe47797dbb69cffc40e70..e929797206f6d5ceac36011e46050865ab9a5b91 100644 (file)
--- a/drivers/media/pci/bt8xx/dst.c
+++ b/drivers/media/pci/bt8xx/dst.c
@@ -1100,8 +1100,8 @@ static int dst_get_device_id(struct dst_state *state)
                        /*      Card capabilities       */
                        state->dst_hw_cap = p_dst_type->dst_feature;
                        pr_err("Recognise [%s]\n", p_dst_type->device_id);
-                       strscpy((char *)state->fw_name, p_dst_type->device_id,
-                               sizeof(state->fw_name));
+                       strscpy(state->fw_name, p_dst_type->device_id,
+                               sizeof(state->fw_name));
                        /*      Multiple tuners         */
                        if (p_dst_type->tuner_type & TUNER_TYPE_MULTI) {
                                switch (use_dst_type) {

diff --git a/drivers/media/pci/bt8xx/dst_common.h b/drivers/media/pci/bt8xx/dst_common.h
index 6a2cfdd44e3e36773d39d5ca97f13822a5c43e75..79dec1b1722ccb79f96c8fb60b574fdeab6a944b 100644 (file)
--- a/drivers/media/pci/bt8xx/dst_common.h
+++ b/drivers/media/pci/bt8xx/dst_common.h
@@ -138,7 +138,7 @@ struct dst_state {
        u32 tuner_type;
        char *tuner_name;
        struct mutex dst_mutex;
-       u8 fw_name[8];
+       char fw_name[8];
        struct dvb_device *dst_ca;
 };