sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
authorzhuyj <zyjzyj2000@gmail.com>
Wed, 20 Aug 2014 09:31:43 +0000 (17:31 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Aug 2014 04:33:17 +0000 (21:33 -0700)
Since the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and it
always has been, so it is unnecessary to bug the user with a
notification.

Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@gmail.com>
Suggested-by: Vlad Yasevich <vyasevich@gmail.com>
Suggested-by: Michael Tuexen <tuexen@fh-muenster.de>
Suggested-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/associola.c

index 06a9ee6b2d3a577a73b62028a711f5f801fe13f0..aaafb3250c6a5c6eec9c9a5401c6f4f6129bcfd5 100644 (file)
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
                else {
                        dst_release(transport->dst);
                        transport->dst = NULL;
+                       ulp_notify = false;
                }
 
                spc_state = SCTP_ADDR_UNREACHABLE;