xen/gntdev: Check and release imported dma-bufs on close
authorOleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thu, 14 Feb 2019 14:23:21 +0000 (16:23 +0200)
committerJuergen Gross <jgross@suse.com>
Mon, 18 Feb 2019 05:50:10 +0000 (06:50 +0100)
Check if there are any imported dma-bufs left not released by
user-space when grant device's release callback is called and
free those if this is the case. This can happen if user-space
leaks the buffers because of a bug or application has been
terminated for any reason.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Boris Ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/gntdev-dmabuf.c

index d97fcfc5e55879ff42513d009ef26fb345369fa6..2c4f324f862611eeb8acf4a268908b1da57c27c8 100644 (file)
@@ -745,6 +745,14 @@ static int dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 fd)
        return 0;
 }
 
+static void dmabuf_imp_release_all(struct gntdev_dmabuf_priv *priv)
+{
+       struct gntdev_dmabuf *q, *gntdev_dmabuf;
+
+       list_for_each_entry_safe(gntdev_dmabuf, q, &priv->imp_list, next)
+               dmabuf_imp_release(priv, gntdev_dmabuf->fd);
+}
+
 /* DMA buffer IOCTL support. */
 
 long gntdev_ioctl_dmabuf_exp_from_refs(struct gntdev_priv *priv, int use_ptemod,
@@ -862,5 +870,6 @@ struct gntdev_dmabuf_priv *gntdev_dmabuf_init(struct file *filp)
 
 void gntdev_dmabuf_fini(struct gntdev_dmabuf_priv *priv)
 {
+       dmabuf_imp_release_all(priv);
        kfree(priv);
 }