NFC: nfcmrvl_usb: use interface as phy device
authorJohan Hovold <johan@kernel.org>
Thu, 30 Mar 2017 10:15:41 +0000 (12:15 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 18 Jun 2017 21:57:59 +0000 (23:57 +0200)
Use the USB-interface rather than parent USB-device device, which is
what this driver binds to, when registering the nci device.

Note that using the right device is important when dealing with device-
managed resources as the interface can be unbound independently of the
parent device.

Also note that private device pointer had already been set by
nfcmrvl_nci_register_dev() so the redundant assignment can therefore be
removed.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/nfcmrvl/usb.c

index 699aa9d1657532c7d15e46c2c2e178f02c175517..bd35eab652be7cf503adc7d253ecb5ccab7d9ad0 100644 (file)
@@ -341,15 +341,13 @@ static int nfcmrvl_probe(struct usb_interface *intf,
        init_usb_anchor(&drv_data->deferred);
 
        priv = nfcmrvl_nci_register_dev(NFCMRVL_PHY_USB, drv_data, &usb_ops,
-                                       &drv_data->udev->dev, &config);
+                                       &intf->dev, &config);
        if (IS_ERR(priv))
                return PTR_ERR(priv);
 
        drv_data->priv = priv;
        drv_data->priv->support_fw_dnld = false;
 
-       priv->dev = &drv_data->udev->dev;
-
        usb_set_intfdata(intf, drv_data);
 
        return 0;