drm/amd/powerplay: initialize a variable before using it

Function vega10_apply_state_adjust_rules() only initializes
stable_pstate_sclk_dpm_percentage when
data->registry_data.stable_pstate_sclk_dpm_percentage is not between 1
and 100. The variable is then used to compute stable_pstate_sclk, which
therefore uses an uninitialized value.

Fix this by initializing stable_pstate_sclk_dpm_percentage to
data->registry_data.stable_pstate_sclk_dpm_percentage.

This issue has been found while building the kernel with clang. The
compiler reported a -Wsometimes-uninitialized warning.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Fixes: f83a9991648b ("drm/amd/powerplay: add Vega10 powerplay support (v5)")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index b66df60afe0122018f21b91c91a544b2f667bf3d..4f79c21f27ed451451280156afbe9e0ec0c72409 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -3138,6 +3138,8 @@ static int vega10_apply_state_adjust_rules(struct pp_hwmgr *hwmgr,
        minimum_clocks.memoryClock = hwmgr->display_config.min_mem_set_clock;
 
        if (PP_CAP(PHM_PlatformCaps_StablePState)) {
+               stable_pstate_sclk_dpm_percentage =
+                       data->registry_data.stable_pstate_sclk_dpm_percentage;
                PP_ASSERT_WITH_CODE(
                        data->registry_data.stable_pstate_sclk_dpm_percentage >= 1 &&
                        data->registry_data.stable_pstate_sclk_dpm_percentage <= 100,