crypto: s5p-sss - Remove useless check for non-null request
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 1 Mar 2018 20:50:12 +0000 (21:50 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 9 Mar 2018 14:45:46 +0000 (22:45 +0800)
ahash_request 'req' argument passed by the caller
s5p_hash_handle_queue() cannot be NULL here because it is obtained from
non-NULL pointer via container_of().

This fixes smatch warning:
    drivers/crypto/s5p-sss.c:1213 s5p_hash_prepare_request() warn: variable dereferenced before check 'req' (see line 1208)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/s5p-sss.c

index 5d64c08b7f47ef412916b804256716f6f8016779..d7c8163e506862e3982da6f788a57494461f42ce 100644 (file)
@@ -1210,9 +1210,6 @@ static int s5p_hash_prepare_request(struct ahash_request *req, bool update)
        int xmit_len, hash_later, nbytes;
        int ret;
 
-       if (!req)
-               return 0;
-
        if (update)
                nbytes = req->nbytes;
        else