media: coda: retire coda_buf_is_end_of_stream
authorPhilipp Zabel <p.zabel@pengutronix.de>
Tue, 18 Jun 2019 16:45:27 +0000 (12:45 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 24 Jun 2019 18:42:49 +0000 (14:42 -0400)
Using the output queue sequence counter to determine the last buffer to
be encoded or decoded always was fragile at best. Now that we have the
last buffer flag propagating from the output queue to the capture queue
correctly, this is not needed anymore.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/coda/coda-common.c

index d0de3b325b14d7bc6f6e885a7b3d5e69d1667aa8..46f2bb6febdef11c0f63e5ce0851ed39ca26e97d 100644 (file)
@@ -900,13 +900,6 @@ static int coda_dqbuf(struct file *file, void *priv, struct v4l2_buffer *buf)
        return ret;
 }
 
-static bool coda_buf_is_end_of_stream(struct coda_ctx *ctx,
-                                     struct vb2_v4l2_buffer *buf)
-{
-       return ((ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) &&
-               (buf->sequence == (ctx->qsequence - 1)));
-}
-
 void coda_m2m_buf_done(struct coda_ctx *ctx, struct vb2_v4l2_buffer *buf,
                       enum vb2_buffer_state state)
 {
@@ -914,11 +907,8 @@ void coda_m2m_buf_done(struct coda_ctx *ctx, struct vb2_v4l2_buffer *buf,
                .type = V4L2_EVENT_EOS
        };
 
-       if (coda_buf_is_end_of_stream(ctx, buf)) {
-               buf->flags |= V4L2_BUF_FLAG_LAST;
-
+       if (buf->flags & V4L2_BUF_FLAG_LAST)
                v4l2_event_queue_fh(&ctx->fh, &eos_event);
-       }
 
        v4l2_m2m_buf_done(buf, state);
 }