usb-storage: remove single-use define for debugging
authorMatthias Maennich <maennich@google.com>
Tue, 13 Aug 2019 12:17:06 +0000 (13:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Aug 2019 13:11:57 +0000 (15:11 +0200)
USB_STORAGE was defined as "usb-storage: " and used in a single location
as argument to printk. In order to be able to use the name
'USB_STORAGE', drop the definition and use the string directly for the
printk call.

Signed-off-by: Matthias Maennich <maennich@google.com>
Link: https://lore.kernel.org/r/20190813121733.52480-10-maennich@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/debug.h
drivers/usb/storage/scsiglue.c

index 6d64f342f58706cbfc579797e2e86686d6a467b3..16ce06039a4d180c676353dda09062b90bafe892 100644 (file)
@@ -29,8 +29,6 @@
 
 #include <linux/kernel.h>
 
-#define USB_STORAGE "usb-storage: "
-
 #ifdef CONFIG_USB_STORAGE_DEBUG
 void usb_stor_show_command(const struct us_data *us, struct scsi_cmnd *srb);
 void usb_stor_show_sense(const struct us_data *us, unsigned char key,
index 05b80211290d3e2df528eee1ef5065b71f9e9e39..df4de8323eff91cc462d2a20d3c4c71627a80c41 100644 (file)
@@ -379,7 +379,7 @@ static int queuecommand_lck(struct scsi_cmnd *srb,
 
        /* check for state-transition errors */
        if (us->srb != NULL) {
-               printk(KERN_ERR USB_STORAGE "Error in %s: us->srb = %p\n",
+               printk(KERN_ERR "usb-storage: Error in %s: us->srb = %p\n",
                        __func__, us->srb);
                return SCSI_MLQUEUE_HOST_BUSY;
        }