ALSA: hda - Correct aamix output paths
authorTakashi Iwai <tiwai@suse.de>
Fri, 4 Jan 2013 14:41:41 +0000 (15:41 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 12 Jan 2013 07:43:40 +0000 (08:43 +0100)
The output paths including aamix should be parsed only for the first
output.  The surround paths including aamix must be wrong, since it
would mix all streams, i.e. all channels would be mixed into a single
and multiplexed again.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_generic.c

index 4e49c5e277042e2921f288e2d359a93fb50335ee..e7574a863d21b4fe5f6a4d449fcbbcb3ad79c2f7 100644 (file)
@@ -918,7 +918,7 @@ static int try_assign_dacs(struct hda_codec *codec, int num_outs,
                                badness += bad->no_dac;
                }
                path = snd_hda_add_new_path(codec, dac, pin, HDA_PARSE_NO_AAMIX);
-               if (!path && i > 0 && spec->mixer_nid) {
+               if (!path && !i && spec->mixer_nid) {
                        /* try with aamix */
                        path = snd_hda_add_new_path(codec, dac, pin, HDA_PARSE_ALL);
                }
@@ -1102,7 +1102,7 @@ static bool map_singles(struct hda_codec *codec, int outs,
                if (!dac)
                        continue;
                path = snd_hda_add_new_path(codec, dac, pins[i], HDA_PARSE_NO_AAMIX);
-               if (!path && i > 0 && spec->mixer_nid)
+               if (!path && !i && spec->mixer_nid)
                        path = snd_hda_add_new_path(codec, dac, pins[i], HDA_PARSE_ALL);
                if (path) {
                        dacs[i] = dac;