perf evlist: Remove evlist->overwrite
authorWang Nan <wangnan0@huawei.com>
Sun, 3 Dec 2017 02:00:39 +0000 (02:00 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 5 Dec 2017 18:43:54 +0000 (15:43 -0300)
evlist->overwrite is set to false in all users. It can be removed.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Link: http://lkml.kernel.org/r/20171203020044.81680-4-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-record.c
tools/perf/util/evlist.c
tools/perf/util/evlist.h

index 08070f87d4890295f906fba3585e007e4a7ab6ae..3bc6ceeae1f955d20a51fa6b57058d4dec97c8e4 100644 (file)
@@ -500,7 +500,7 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
                struct auxtrace_mmap *mm = &maps[i].auxtrace_mmap;
 
                if (maps[i].base) {
-                       if (perf_mmap__push(&maps[i], evlist->overwrite, backward, rec, record__pushfn) != 0) {
+                       if (perf_mmap__push(&maps[i], false, backward, rec, record__pushfn) != 0) {
                                rc = -1;
                                goto out;
                        }
index 93272d93240789ec2295610a5bde3a4cbffb43fd..a59134fb141f4de74664bdc9a6c8449cce8b926a 100644 (file)
@@ -711,7 +711,7 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int
         * No need for read-write ring buffer: kernel stop outputting when
         * it hit md->prev (perf_mmap__consume()).
         */
-       return perf_mmap__read_forward(md, evlist->overwrite);
+       return perf_mmap__read_forward(md, false);
 }
 
 union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
@@ -738,7 +738,7 @@ void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx)
 
 void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx)
 {
-       perf_mmap__consume(&evlist->mmap[idx], evlist->overwrite);
+       perf_mmap__consume(&evlist->mmap[idx], false);
 }
 
 static void perf_evlist__munmap_nofree(struct perf_evlist *evlist)
@@ -1070,7 +1070,6 @@ int perf_evlist__mmap_ex(struct perf_evlist *evlist, unsigned int pages,
        if (evlist->pollfd.entries == NULL && perf_evlist__alloc_pollfd(evlist) < 0)
                return -ENOMEM;
 
-       evlist->overwrite = false;
        evlist->mmap_len = perf_evlist__mmap_size(pages);
        pr_debug("mmap size %zuB\n", evlist->mmap_len);
        mp.mask = evlist->mmap_len - page_size - 1;
index 424a3d6015afa6ff7f624b8a61f5b48d90813bb3..eec33770b8e64858ba7199bcaed32130e2caf7cf 100644 (file)
@@ -31,7 +31,6 @@ struct perf_evlist {
        int              nr_entries;
        int              nr_groups;
        int              nr_mmaps;
-       bool             overwrite;
        bool             enabled;
        bool             has_user_cpus;
        size_t           mmap_len;