typhoon: wait for RX mode commands to finish
authorDavid Dillow <dave@thedillows.org>
Sun, 24 Oct 2010 10:20:20 +0000 (10:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 24 Oct 2010 23:25:40 +0000 (16:25 -0700)
When adding VLAN devices, we can get several calls to
typhoon_set_rx_mode() in quick succession. Because we didn't wait for
the commands to complete, we could run out of command descriptors and
fail to set the RX mode.

Signed-off-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/typhoon.c

index 1cc67138adbf4a248294a029295df268bfbbc710..5957d4ecd86b12886b65c6ab90509f1d6e5cf987 100644 (file)
@@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev)
                filter |= TYPHOON_RX_FILTER_MCAST_HASH;
        }
 
-       INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER);
+       INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER);
        xp_cmd.parm1 = filter;
        typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL);
 }