ASoC: cs53l30: Fix bit shift issue of TDM mode
authorNicolin Chen <nicoleotsuka@gmail.com>
Tue, 19 Jul 2016 22:36:14 +0000 (15:36 -0700)
committerMark Brown <broonie@kernel.org>
Thu, 21 Jul 2016 11:07:59 +0000 (12:07 +0100)
The TDM mode using PCM format now has two-bit right shift due to the
format configuration in the driver. According to Figure 4-13 in the
CS53L30 datasheet, using ASP_SCLK_INV = 0 and SHIFT_LEFT = 1 should
be the correct combination to create one-bit right shift for the DSP
type A format.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs53l30.c

index fd5502e3aa34abffbc61362da004bc1d08cf263c..2c0d9c430a8ca3d7cef2600b062a95ceb923a4e1 100644 (file)
@@ -592,8 +592,12 @@ static int cs53l30_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                aspctl1 |= CS53L30_ASP_TDM_PDN;
                break;
        case SND_SOC_DAIFMT_DSP_A:
-               /* Clear TDM_PDN and SHIFT_LEFT, invert SCLK */
-               aspcfg |= CS53L30_ASP_SCLK_INV;
+               /*
+                * Clear TDM_PDN to turn on TDM mode; Use ASP_SCLK_INV = 0
+                * with SHIFT_LEFT = 1 combination as Figure 4-13 shows in
+                * the CS53L30 datasheet
+                */
+               aspctl1 |= CS53L30_SHIFT_LEFT;
                break;
        default:
                return -EINVAL;