block: add cmd_flags to print_req_error
authorBalbir Singh <sblbir@amzn.com>
Tue, 30 Oct 2018 02:40:15 +0000 (02:40 +0000)
committerJens Axboe <axboe@kernel.dk>
Sat, 1 Dec 2018 18:39:38 +0000 (11:39 -0700)
I ran into a bug where after hibernation due to incompatible
backends, the block driver returned BLK_STS_NOTSUPP, with the
current message it's hard to find out what the command flags
were. Adding req->cmd_flags help make the problem easier to
diagnose.

Reviewed-by: Eduardo Valentin <eduval@amazon.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Balbir Singh <sblbir@amzn.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c

index 3f6f5e6c2fe43cd9ef667d47d4998c2a54811338..a1a5e1c1489804bb0f46b68b107500f5459758d9 100644 (file)
@@ -173,10 +173,11 @@ static void print_req_error(struct request *req, blk_status_t status)
        if (WARN_ON_ONCE(idx >= ARRAY_SIZE(blk_errors)))
                return;
 
-       printk_ratelimited(KERN_ERR "%s: %s error, dev %s, sector %llu\n",
-                          __func__, blk_errors[idx].name, req->rq_disk ?
-                          req->rq_disk->disk_name : "?",
-                          (unsigned long long)blk_rq_pos(req));
+       printk_ratelimited(KERN_ERR "%s: %s error, dev %s, sector %llu flags %x\n",
+                               __func__, blk_errors[idx].name,
+                               req->rq_disk ?  req->rq_disk->disk_name : "?",
+                               (unsigned long long)blk_rq_pos(req),
+                               req->cmd_flags);
 }
 
 static void req_bio_endio(struct request *rq, struct bio *bio,