fs: avoid fdput() after failed fdget() in vfs_dedupe_file_range()

It's a fairly inconsequential bug, since fdput() won't actually try to
fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in
the failure case, but most other vfs code takes steps to avoid this.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/fs/read_write.c b/fs/read_write.c
index c4eabbfc90df9a266994631f9ac29ba0489de20b..e83bd9744b5d3b9d81b0a95898a91ed0ec9ebce7 100644 (file)
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -2023,7 +2023,7 @@ int vfs_dedupe_file_range(struct file *file, struct file_dedupe_range *same)
                ret = mnt_want_write_file(dst_file);
                if (ret) {
                        info->status = ret;
-                       goto next_loop;
+                       goto next_fdput;
                }
 
                dst_off = info->dest_offset;
@@ -2058,9 +2058,9 @@ int vfs_dedupe_file_range(struct file *file, struct file_dedupe_range *same)
 
 next_file:
                mnt_drop_write_file(dst_file);
-next_loop:
+next_fdput:
                fdput(dst_fd);
-
+next_loop:
                if (fatal_signal_pending(current))
                        goto out;
        }