genirq/timings: Move free timings out of spinlocked region
authorThomas Gleixner <tglx@linutronix.de>
Thu, 29 Jun 2017 21:33:39 +0000 (23:33 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 4 Jul 2017 10:46:16 +0000 (12:46 +0200)
No point to do memory management from a interrupt disabled spin locked
region.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Julia Cartwright <julia@ni.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>
Cc: linux-rockchip@lists.infradead.org
Cc: John Keeping <john@metanate.com>
Cc: linux-gpio@vger.kernel.org
Link: http://lkml.kernel.org/r/20170629214344.196130646@linutronix.de
kernel/irq/manage.c

index 3e693430bfe1afd2b37e41b3de609541446f74dd..91e1f2390752cb443c822957976a3e7aba867811 100644 (file)
@@ -1489,7 +1489,6 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id)
        if (!desc->action) {
                irq_settings_clr_disable_unlazy(desc);
                irq_shutdown(desc);
-               irq_remove_timings(desc);
        }
 
 #ifdef CONFIG_SMP
@@ -1531,8 +1530,10 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id)
                }
        }
 
-       if (!desc->action)
+       if (!desc->action) {
                irq_release_resources(desc);
+               irq_remove_timings(desc);
+       }
 
        mutex_unlock(&desc->request_mutex);