ASoC: rockchip: pdm: optimize clear logic
authorSugar Zhang <sugar.zhang@rock-chips.com>
Wed, 3 Apr 2019 13:40:48 +0000 (21:40 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 4 Apr 2019 08:04:25 +0000 (15:04 +0700)
There is no need to reset controller every time, do this
once in pdm_probe.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_pdm.c

index 984d99889a65ac03bb9153e37801e7a4e0e4d72e..eb5216dd7dbc8b24b4fb80c40df8ef96c97f82f4 100644 (file)
@@ -183,9 +183,6 @@ static int rockchip_pdm_hw_params(struct snd_pcm_substream *substream,
                                   val);
                regmap_update_bits(pdm->regmap, PDM_DMA_CTRL, PDM_DMA_RDL_MSK,
                                   PDM_DMA_RDL(16));
-               regmap_update_bits(pdm->regmap, PDM_SYSCONFIG,
-                                  PDM_RX_MASK | PDM_RX_CLR_MASK,
-                                  PDM_RX_STOP | PDM_RX_CLR_WR);
        }
 
        return 0;
@@ -353,6 +350,7 @@ static bool rockchip_pdm_volatile_reg(struct device *dev, unsigned int reg)
 {
        switch (reg) {
        case PDM_SYSCONFIG:
+       case PDM_FIFO_CTRL:
        case PDM_INT_CLR:
        case PDM_INT_ST:
                return true;
@@ -436,6 +434,7 @@ static int rockchip_pdm_probe(struct platform_device *pdev)
                goto err_suspend;
        }
 
+       rockchip_pdm_rxctrl(pdm, 0);
        ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
        if (ret) {
                dev_err(&pdev->dev, "could not register pcm: %d\n", ret);