RDMA/cxgb4: remove redundant null pointer check before kfree_skb

kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 0f83cbec33f3464e0558fb71871f508264e4d982..615413bd3e8d79744fe5ef9c168e86b836f15574 100644 (file)
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -403,8 +403,7 @@ void _c4iw_free_ep(struct kref *kref)
                                 ep->com.local_addr.ss_family);
                dst_release(ep->dst);
                cxgb4_l2t_release(ep->l2t);
-               if (ep->mpa_skb)
-                       kfree_skb(ep->mpa_skb);
+               kfree_skb(ep->mpa_skb);
        }
        if (!skb_queue_empty(&ep->com.ep_skb_list))
                skb_queue_purge(&ep->com.ep_skb_list);

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index 347fe18b1a41c0990c753aa29f2efaaea0cd119b..e78dd9afac86b8753fd8f1bc1747df22cb2db7ae 100644 (file)
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -2813,8 +2813,7 @@ err_free_queue:
        free_srq_queue(srq, ucontext ? &ucontext->uctx : &rhp->rdev.uctx,
                       srq->wr_waitp);
 err_free_skb:
-       if (srq->destroy_skb)
-               kfree_skb(srq->destroy_skb);
+       kfree_skb(srq->destroy_skb);
 err_free_srq_idx:
        c4iw_free_srq_idx(&rhp->rdev, srq->idx);
 err_free_wr_wait: