net/udp_offload: Use IS_ERR_OR_NULL
authorHimangi Saraogi <himangi774@gmail.com>
Sun, 27 Jul 2014 07:08:38 +0000 (12:38 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Jul 2014 22:31:56 +0000 (15:31 -0700)
This patch introduces the use of the macro IS_ERR_OR_NULL in place of
tests for NULL and IS_ERR.

The following Coccinelle semantic patch was used for making the change:

@@
expression e;
@@

- e == NULL || IS_ERR(e)
+ IS_ERR_OR_NULL(e)
 || ...

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp_offload.c

index 4807544d018bd52af5da86e7388853fb04c57ce9..59035bc3008d2bc45ec87e9eea4145120bf664be 100644 (file)
@@ -79,7 +79,7 @@ struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb,
        /* segment inner packet. */
        enc_features = skb->dev->hw_enc_features & netif_skb_features(skb);
        segs = skb_mac_gso_segment(skb, enc_features);
-       if (!segs || IS_ERR(segs)) {
+       if (IS_ERR_OR_NULL(segs)) {
                skb_gso_error_unwind(skb, protocol, tnl_hlen, mac_offset,
                                     mac_len);
                goto out;