s5p-mfc: Set device name for reserved memory region devs
authorJavier Martinez Canillas <javier@osg.samsung.com>
Tue, 3 May 2016 20:27:16 +0000 (16:27 -0400)
committerSylwester Nawrocki <s.nawrocki@samsung.com>
Fri, 3 Jun 2016 09:10:37 +0000 (11:10 +0200)
The devices don't have a name set, so makes dev_name() returns NULL which
makes harder to identify the devices that are causing issues, for example:

WARNING: CPU: 2 PID: 616 at drivers/base/core.c:251 device_release+0x8c/0x90
Device '(null)' does not have a release() function, it is broken and must be fixed.

And after setting the device name:

WARNING: CPU: 0 PID: 591 at drivers/base/core.c:251 device_release+0x8c/0x90
Device 's5p-mfc-l' does not have a release() function, it is broken and must be fixed.

Cc: <stable@vger.kernel.org>
Fixes: 6e83e6e25eb4 ("[media] s5p-mfc: Fix kernel warning on memory init")
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
drivers/media/platform/s5p-mfc/s5p_mfc.c

index b16466fe35ee1dfa660305020875fbb2c6f77986..8fc1fd4ee2ed110eebc97f76ac746745427a72e0 100644 (file)
@@ -1062,6 +1062,8 @@ static int s5p_mfc_alloc_memdevs(struct s5p_mfc_dev *dev)
                mfc_err("Not enough memory\n");
                return -ENOMEM;
        }
+
+       dev_set_name(dev->mem_dev_l, "%s", "s5p-mfc-l");
        device_initialize(dev->mem_dev_l);
        of_property_read_u32_array(dev->plat_dev->dev.of_node,
                        "samsung,mfc-l", mem_info, 2);
@@ -1079,6 +1081,8 @@ static int s5p_mfc_alloc_memdevs(struct s5p_mfc_dev *dev)
                mfc_err("Not enough memory\n");
                return -ENOMEM;
        }
+
+       dev_set_name(dev->mem_dev_r, "%s", "s5p-mfc-r");
        device_initialize(dev->mem_dev_r);
        of_property_read_u32_array(dev->plat_dev->dev.of_node,
                        "samsung,mfc-r", mem_info, 2);