perf tests record: Allow for 'sleep' being 'coreutils'
authorAdrian Hunter <adrian.hunter@intel.com>
Thu, 22 Nov 2018 13:55:45 +0000 (15:55 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 Dec 2018 17:54:26 +0000 (14:54 -0300)
If the 'sleep' command is provided by coreutils, then the "PERF_RECORD_*
events & perf_sample fields" test will fail because the MMAP name is
'coreutils' not 'sleep', and there is an extra COMM event. Fix the test
to detect that case.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/20181122135545.16295-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/perf-record.c

index 34394cc0507748630eb83dbadeb4d73bd4f9e9f3..07f6bd8ed719d9320dd106690a6b3bf92d415cc3 100644 (file)
@@ -58,6 +58,7 @@ int test__PERF_RECORD(struct test *test __maybe_unused, int subtest __maybe_unus
        char *bname, *mmap_filename;
        u64 prev_time = 0;
        bool found_cmd_mmap = false,
+            found_coreutils_mmap = false,
             found_libc_mmap = false,
             found_vdso_mmap = false,
             found_ld_mmap = false;
@@ -254,6 +255,8 @@ int test__PERF_RECORD(struct test *test __maybe_unused, int subtest __maybe_unus
                                        if (bname != NULL) {
                                                if (!found_cmd_mmap)
                                                        found_cmd_mmap = !strcmp(bname + 1, cmd);
+                                               if (!found_coreutils_mmap)
+                                                       found_coreutils_mmap = !strcmp(bname + 1, "coreutils");
                                                if (!found_libc_mmap)
                                                        found_libc_mmap = !strncmp(bname + 1, "libc", 4);
                                                if (!found_ld_mmap)
@@ -292,7 +295,7 @@ int test__PERF_RECORD(struct test *test __maybe_unused, int subtest __maybe_unus
        }
 
 found_exit:
-       if (nr_events[PERF_RECORD_COMM] > 1) {
+       if (nr_events[PERF_RECORD_COMM] > 1 + !!found_coreutils_mmap) {
                pr_debug("Excessive number of PERF_RECORD_COMM events!\n");
                ++errs;
        }
@@ -302,7 +305,7 @@ found_exit:
                ++errs;
        }
 
-       if (!found_cmd_mmap) {
+       if (!found_cmd_mmap && !found_coreutils_mmap) {
                pr_debug("PERF_RECORD_MMAP for %s missing!\n", cmd);
                ++errs;
        }