perf evlist: Store 'overwrite' in struct perf_mmap
authorKan Liang <kan.liang@linux.intel.com>
Tue, 6 Mar 2018 15:36:00 +0000 (10:36 -0500)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 8 Mar 2018 13:05:50 +0000 (10:05 -0300)
It has been determined that the map is for overwrite mode
(evlist->overwrite_mmap) or non-overwrite mode (evlist->mmap) when
calling perf_evlist__alloc_mmap().

Store the information in struct perf_mmap, which will be used later to
simplify the perf_mmap__read*() interfaces.

Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Suggested-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1520350567-80082-1-git-send-email-kan.liang@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evlist.c
tools/perf/util/mmap.h

index 41a4666f1519b1a1207bf23858cabe7567485822..a59281d6436884e918147222e60ee0ee5b84c0f3 100644 (file)
@@ -722,7 +722,8 @@ void perf_evlist__munmap(struct perf_evlist *evlist)
        zfree(&evlist->overwrite_mmap);
 }
 
-static struct perf_mmap *perf_evlist__alloc_mmap(struct perf_evlist *evlist)
+static struct perf_mmap *perf_evlist__alloc_mmap(struct perf_evlist *evlist,
+                                                bool overwrite)
 {
        int i;
        struct perf_mmap *map;
@@ -736,6 +737,7 @@ static struct perf_mmap *perf_evlist__alloc_mmap(struct perf_evlist *evlist)
 
        for (i = 0; i < evlist->nr_mmaps; i++) {
                map[i].fd = -1;
+               map[i].overwrite = overwrite;
                /*
                 * When the perf_mmap() call is made we grab one refcount, plus
                 * one extra to let perf_mmap__consume() get the last
@@ -779,7 +781,7 @@ static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx,
                        maps = evlist->overwrite_mmap;
 
                        if (!maps) {
-                               maps = perf_evlist__alloc_mmap(evlist);
+                               maps = perf_evlist__alloc_mmap(evlist, true);
                                if (!maps)
                                        return -1;
                                evlist->overwrite_mmap = maps;
@@ -1029,7 +1031,7 @@ int perf_evlist__mmap_ex(struct perf_evlist *evlist, unsigned int pages,
        struct mmap_params mp;
 
        if (!evlist->mmap)
-               evlist->mmap = perf_evlist__alloc_mmap(evlist);
+               evlist->mmap = perf_evlist__alloc_mmap(evlist, false);
        if (!evlist->mmap)
                return -ENOMEM;
 
index ec7d3a24e276fbbe16aff12abf56363cc684cce5..71137977af2830816d1127ecb15fff707af2c96c 100644 (file)
@@ -20,6 +20,7 @@ struct perf_mmap {
        int              fd;
        refcount_t       refcnt;
        u64              prev;
+       bool             overwrite;
        struct auxtrace_mmap auxtrace_mmap;
        char             event_copy[PERF_SAMPLE_MAX_SIZE] __aligned(8);
 };