blk-throttle: remove spurious throtl_enqueue_tg() call from throtl_select_dispatch()
authorTejun Heo <tj@kernel.org>
Tue, 14 May 2013 20:52:31 +0000 (13:52 -0700)
committerTejun Heo <tj@kernel.org>
Tue, 14 May 2013 20:52:31 +0000 (13:52 -0700)
throtl_select_dispatch() calls throtl_enqueue_tg() right after
tg_update_disptime(), which always calls the function anyway.  The
call is, while harmless, unnecessary.  Remove it.

This patch doesn't introduce any behavior difference.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
block/blk-throttle.c

index 31146225f3d078fb5326e30195a0fa138f1f3e5a..3960787358b609e76dba412e1db75b10674ef0a2 100644 (file)
@@ -816,10 +816,8 @@ static int throtl_select_dispatch(struct throtl_data *td, struct bio_list *bl)
 
                nr_disp += throtl_dispatch_tg(td, tg, bl);
 
-               if (tg->nr_queued[0] || tg->nr_queued[1]) {
+               if (tg->nr_queued[0] || tg->nr_queued[1])
                        tg_update_disptime(td, tg);
-                       throtl_enqueue_tg(td, tg);
-               }
 
                if (nr_disp >= throtl_quantum)
                        break;