scsi: megaraid_sas: Fail init if heartbeat timer fails
authorShivasharan S <shivasharan.srikanteshwara@broadcom.com>
Wed, 17 Oct 2018 06:37:48 +0000 (23:37 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 7 Nov 2018 01:33:57 +0000 (20:33 -0500)
When driver fails to start the heartbeat timer, exit from FW init.

Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c

index 688219404cae6cadba38fb4af47e5254c2601c39..85c7d9912eea717d4dc81926e44c8ea3704af74f 100644 (file)
@@ -5694,10 +5694,12 @@ static int megasas_init_fw(struct megasas_instance *instance)
 
        /* Launch SR-IOV heartbeat timer */
        if (instance->requestorId) {
-               if (!megasas_sriov_start_heartbeat(instance, 1))
+               if (!megasas_sriov_start_heartbeat(instance, 1)) {
                        megasas_start_timer(instance);
-               else
+               } else {
                        instance->skip_heartbeat_timer_del = 1;
+                       goto fail_get_ld_pd_list;
+               }
        }
 
        /*