IB/core: Avoid unnecessary return value check
authorParav Pandit <parav@mellanox.com>
Thu, 2 Nov 2017 13:22:27 +0000 (15:22 +0200)
committerDoug Ledford <dledford@redhat.com>
Mon, 13 Nov 2017 19:42:04 +0000 (14:42 -0500)
Since there is nothing done with non zero return value, such check is
avoided.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/security.c

index 88bdafb297f5fe9f722c7a8edee27554ea3b6862..455cba7f96405c4d4cf006e00c90868837d2aed6 100644 (file)
@@ -692,20 +692,13 @@ void ib_mad_agent_security_cleanup(struct ib_mad_agent *agent)
 
 int ib_mad_enforce_security(struct ib_mad_agent_private *map, u16 pkey_index)
 {
-       int ret;
-
        if (map->agent.qp->qp_type == IB_QPT_SMI && !map->agent.smp_allowed)
                return -EACCES;
 
-       ret = ib_security_pkey_access(map->agent.device,
-                                     map->agent.port_num,
-                                     pkey_index,
-                                     map->agent.security);
-
-       if (ret)
-               return ret;
-
-       return 0;
+       return ib_security_pkey_access(map->agent.device,
+                                      map->agent.port_num,
+                                      pkey_index,
+                                      map->agent.security);
 }
 
 #endif /* CONFIG_SECURITY_INFINIBAND */