jbd2: remove outdated comment
authorJan Kara <jack@suse.cz>
Tue, 4 Jun 2013 16:10:11 +0000 (12:10 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 4 Jun 2013 16:10:11 +0000 (12:10 -0400)
The comment about credit estimates isn't true anymore. We do what the
comment describes now.

Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/jbd2/transaction.c

index 6f4248dd8759e2d2038017e6d70c3a40196fd7ba..60361c634b5d15fd6f0bb1f5bb61ba21054c3686 100644 (file)
@@ -283,16 +283,6 @@ repeat:
         * reduce the free space arbitrarily.  Be careful to account for
         * those buffers when checkpointing.
         */
-
-       /*
-        * @@@ AKPM: This seems rather over-defensive.  We're giving commit
-        * a _lot_ of headroom: 1/4 of the journal plus the size of
-        * the committing transaction.  Really, we only need to give it
-        * committing_transaction->t_outstanding_credits plus "enough" for
-        * the log control blocks.
-        * Also, this test is inconsistent with the matching one in
-        * jbd2_journal_extend().
-        */
        if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) {
                jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle);
                atomic_sub(nblocks, &transaction->t_outstanding_credits);