ALSA: cs46xx: constify snd_kcontrol_new structures
authorBhumika Goyal <bhumirks@gmail.com>
Wed, 17 May 2017 12:09:03 +0000 (17:39 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sun, 21 May 2017 07:08:10 +0000 (09:08 +0200)
Declare snd_kcontrol_new structures as const as they are only passed an
argument to the function snd_ctl_new1. This argument is of type const,
so snd_kcontrol_new structures having this property can be made const.
Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/cs46xx/cs46xx_lib.c

index e4cf3187b4ddb888f8f5676581eaaf721b933f27..00fa52e9a2f2609122252eb17df7655bc9baaeeb 100644 (file)
@@ -2371,7 +2371,7 @@ static int snd_cs46xx_front_dup_put(struct snd_kcontrol *kcontrol,
                                    ucontrol->value.integer.value[0] ? 0 : 0x200);
 }
 
-static struct snd_kcontrol_new snd_cs46xx_front_dup_ctl = {
+static const struct snd_kcontrol_new snd_cs46xx_front_dup_ctl = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "Duplicate Front",
        .info = snd_mixer_boolean_info,